Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Dont warn whenever using controlled version of component #284

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

jgzuke
Copy link
Contributor

@jgzuke jgzuke commented Dec 8, 2020

Right now selects default initialValue to "", but then warn when initialValue is not undefined

📦 Published PR as canary version: 8.7.0-canary.284.6917.0

✨ Test out this PR locally via:

npm install @apollo/space-kit@8.7.0-canary.284.6917.0
# or 
yarn add @apollo/space-kit@8.7.0-canary.284.6917.0

@jgzuke jgzuke added the minor Increment the minor version when merged label Dec 8, 2020
Copy link
Contributor

@justinanastos justinanastos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@justinanastos justinanastos added bug fix Increment the patch version when merged and removed minor Increment the minor version when merged labels Dec 9, 2020
@jgzuke jgzuke merged commit 57363a6 into main Dec 9, 2020
@jgzuke jgzuke deleted the jgzuke/misc/fix-select-initial-value branch December 9, 2020 17:26
@apollo-bot2
Copy link
Collaborator

🚀 PR was released in v8.6.1 🚀

@apollo-bot2 apollo-bot2 added the released This issue/pull request has been released. label Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants